feat: add support for mock da #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e5ccda2.
Base automatically changed from
mtsitrin/157-interactive-cli-improvements-suggestions
to
main
July 4, 2023 07:29
mtsitrin
force-pushed
the
mtsitrin/165-add-support-for-mock-da
branch
from
8ee279d to
236a378
Compare
Closed
cmd/config/init/init.go
Outdated
| return ` | ||
| A valid RollApp ID should follow the format 'name_uniqueID-revision', where | ||
| - 'name' is made up of lowercase English letters | ||
| - 'uniqueID' is a 1 to 5 digit number representing the unique ID EIP155 rollapp ID |
There was a problem hiding this comment.
Suggested change
| - 'uniqueID' is a 1 to 5 digit number representing the unique ID EIP155 rollapp ID | |
| - 'uniqueID' is a number up to the length of 5 digits representing the unique ID EIP155 rollapp ID |
cmd/config/init/init.go
Outdated
| A valid RollApp ID should follow the format 'name_uniqueID-revision', where | ||
| - 'name' is made up of lowercase English letters | ||
| - 'uniqueID' is a 1 to 5 digit number representing the unique ID EIP155 rollapp ID | ||
| - 'revision' is a 1 to 5 digit number representing the revision number for this rollapp |
| dalayer = &damock.DAMock{} | ||
| default: | ||
| //TODO: return error | ||
| panic("Unknown data layer type") |
There was a problem hiding this comment.
Do the todo, it can harm the ux if the user tries to edit the DA manually
There was a problem hiding this comment.
it won't reach here as the args validated beforehand
| startDALCCmd := da_start.GetStartDACmd(rollappConfig, consts.DefaultCelestiaRPC) | ||
| startDALCCmd := damanager.GetStartDACmd(consts.DefaultCelestiaRPC) | ||
| if startDALCCmd == nil { | ||
| return |
There was a problem hiding this comment.
Shouldn't you call waitinggroup.done?
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configpackagedatalayerinterface for da layers to be used by the different commandsPR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: